[webkit-reviews] review granted: [Bug 238264] Prepare JSC for making the String(const char*) constructor explicit : [Attachment 455538] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 23 15:58:53 PDT 2022


Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 238264: Prepare JSC for making the String(const char*) constructor explicit
https://bugs.webkit.org/show_bug.cgi?id=238264

Attachment 455538: Patch

https://bugs.webkit.org/attachment.cgi?id=455538&action=review




--- Comment #8 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 455538
  --> https://bugs.webkit.org/attachment.cgi?id=455538
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455538&action=review

r=me

> Source/JavaScriptCore/API/JSCallbackObjectFunctions.h:214
> -	       className = thisObject->className(vm);
> +	       className =  thisObject->className(vm);

oops?


More information about the webkit-reviews mailing list