[webkit-reviews] review granted: [Bug 238255] Update Sandbox profiles for system content path : [Attachment 455540] Patch with updates from reviews

[bugzilla-daemon at webkit.org]

Per Arne Vollan <pvollan at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 238255: Update Sandbox profiles for system content path
https://bugs.webkit.org/show_bug.cgi?id=238255

Attachment 455540: Patch with updates from reviews

https://bugs.webkit.org/attachment.cgi?id=455540&action=review




--- Comment #11 from Per Arne Vollan <pvollan at apple.com> ---
Comment on attachment 455540
  --> https://bugs.webkit.org/attachment.cgi?id=455540
Patch with updates from reviews

View in context: https://bugs.webkit.org/attachment.cgi?id=455540&action=review

R=me.

>>> Source/WebKit/DerivedSources.make:354
>>> +endif
>> 
>> Perhaps this can be omitted since the preprocess step includes
wtf/Platform.h?
> 
> Platform.h doesn't define the *SYSTEM_CONTENT_PATH values.

Ah, I see, thanks!

>>> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:1105
>>> +#endif
>> 
>> Do you also need to add this to the other WebKit sandboxes on Mac?
> 
> I don't think so.  The value
read-directory-and-issue-read-extension-secondary-paths is used for the system
content path of WebInspectorUI.framework and it is only needed in
WebProcess.sb.in and WebAuthnProcess.sb.in.  Maybe we should choose a different
name for the value, say webinspectorui-secondary-path?

I think that would make it clearer, but not strictly necessary.