[webkit-reviews] review canceled: [Bug 238030] [JSC][MSVC] custom getter creation needs to include classInfo since MSVC ICF is not "safe" variant : [Attachment 455478] Patch

[bugzilla-daemon at webkit.org]

Alexey Shvayka <ashvayka at apple.com> has canceled Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 238030: [JSC][MSVC] custom getter creation needs to include classInfo since
MSVC ICF is not "safe" variant
https://bugs.webkit.org/show_bug.cgi?id=238030

Attachment 455478: Patch

https://bugs.webkit.org/attachment.cgi?id=455478&action=review




--- Comment #8 from Alexey Shvayka <ashvayka at apple.com> ---
Comment on attachment 455478
  --> https://bugs.webkit.org/attachment.cgi?id=455478
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455478&action=review

> Source/JavaScriptCore/ChangeLog:12
> +	   Since JSCustomGetterFunction does separate thing based on attached
DOMAttribute, we need to include const ClassInfo*

There is no way we can use slotBase() pointer instead, right? To fix the issue
for all possibly accessors rather than only DOMAttribute?