[webkit-reviews] review granted: [Bug 238252] [Forms] Alias appearance <compat-auto> keywords to 'auto' for button : [Attachment 455502] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted zsun at igalia.com's request for review:
Bug 238252: [Forms] Alias appearance <compat-auto> keywords to 'auto' for
button
https://bugs.webkit.org/show_bug.cgi?id=238252

Attachment 455502: Patch

https://bugs.webkit.org/attachment.cgi?id=455502&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 455502
  --> https://bugs.webkit.org/attachment.cgi?id=455502
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455502&action=review

> Source/WebCore/ChangeLog:9
> +	   handle some button ralted cases including button, push-button and
square-button.

ralted -> related

> LayoutTests/fast/forms/file/file-style-inheritance.html:9
> -    /* Uses square-button for ease of testing on Mac. */
> -    -webkit-appearance: square-button;
> +    /* Uses none for ease of testing on Mac. */
> +    -webkit-appearance: none;

Does this still test what it intends to, given that it’s using "none" for
appearance?