[webkit-reviews] review denied: [Bug 236272] [css] Can't revert low-priority properties like text-decoration : [Attachment 454640] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has denied  review:
Bug 236272: [css] Can't revert low-priority properties like text-decoration
https://bugs.webkit.org/show_bug.cgi?id=236272

Attachment 454640: Patch

https://bugs.webkit.org/attachment.cgi?id=454640&action=review




--- Comment #9 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 454640
  --> https://bugs.webkit.org/attachment.cgi?id=454640
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454640&action=review

> Source/WebCore/style/PropertyCascade.cpp:176
> +    m_deferredPropertiesIndices.set(id, m_deferredProperties.size());

It is not ok to add a HashMap (and a heap allocation) to this generic code path
when it is only needed and used in the rare rollback case. The code should be
structured differently.