[webkit-reviews] review granted: [Bug 236965] After losing context due to too many contexts, getError() does not return CONTEXT_LOST_WEBGL : [Attachment 455373] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 236965: After losing context due to too many contexts, getError() does not
return CONTEXT_LOST_WEBGL
https://bugs.webkit.org/show_bug.cgi?id=236965

Attachment 455373: Patch

https://bugs.webkit.org/attachment.cgi?id=455373&action=review




--- Comment #5 from Kenneth Russell <kbr at google.com> ---
Comment on attachment 455373
  --> https://bugs.webkit.org/attachment.cgi?id=455373
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455373&action=review

Seems fine given that the tests progress. If it's possible to add more WebGL
conformance tests covering this area, please do. r+

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:7754
> +	   ASSERT_NOT_REACHED();

Just checking - this assert is not hit if the WEBGL_lose_context extension is
used incorrectly? (restoreContext() is called, but preventDefault() wasn't
called against the lost context event?) I assume that WEBGL_lose_context's
validation will catch this misuse - and that the EWS bots are running enough
WebGL conformance tests using the WEBGL_lose_context extension.