[webkit-reviews] review granted: [Bug 236440] Safari can't play video completely at bilibili.com : [Attachment 455449] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Jean-Yves Avenard [:jya]
<jean-yves.avenard at apple.com>'s request for review:
Bug 236440: Safari can't play video completely at bilibili.com
https://bugs.webkit.org/show_bug.cgi?id=236440

Attachment 455449: Patch

https://bugs.webkit.org/attachment.cgi?id=455449&action=review




--- Comment #11 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 455449
  --> https://bugs.webkit.org/attachment.cgi?id=455449
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455449&action=review

> Source/WebCore/platform/graphics/SourceBufferPrivate.cpp:1262
> +	   // Looking up the prior frame would require a computationally
intensive operation. So instead, as a workaround

I don't think this is strictly true; we could return a pair of iterators from
the `addSample()` code above and step backwards. Perhaps the current behavior
is better though, but it might be best to remove that statement from the
comment.