[webkit-reviews] review granted: [Bug 237676] Web Inspector: Styles panel: Unwanted extra dash when autocompleting CSS variable names : [Attachment 455405] Patch 1.2

[bugzilla-daemon at webkit.org]

Patrick Angle <pangle at apple.com> has granted Razvan Caliman
<rcaliman at apple.com>'s request for review:
Bug 237676: Web Inspector: Styles panel: Unwanted extra dash when
autocompleting CSS variable names
https://bugs.webkit.org/show_bug.cgi?id=237676

Attachment 455405: Patch 1.2

https://bugs.webkit.org/attachment.cgi?id=455405&action=review




--- Comment #11 from Patrick Angle <pangle at apple.com> ---
Comment on attachment 455405
  --> https://bugs.webkit.org/attachment.cgi?id=455405
Patch 1.2

View in context: https://bugs.webkit.org/attachment.cgi?id=455405&action=review

r=me - Nice work!

> LayoutTests/inspector/unit-tests/css-keyword-completions.html:271
>      // `calc(1 + var(|))`

Just for completeness can we add a test case along the lines of `calc(1 - |)`
to ensure that we get an empty prefix here? We should currently, but I could
see a mistake being made in a future change to
`WI.CSSKeywordCompletions.forPartialPropertyValue`, for example if someone
removes the `trim` on :86, which would make the token that is just space appear
to have content and get merged with the preceding `-`.