[webkit-reviews] review granted: [Bug 236069] REGRESSION (iOS 15.1 / r280824) QuickLook - model not loading when passing extra parameters : [Attachment 455388] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 236069: REGRESSION (iOS 15.1 / r280824) QuickLook - model not loading when
passing extra parameters
https://bugs.webkit.org/show_bug.cgi?id=236069

Attachment 455388: Patch

https://bugs.webkit.org/attachment.cgi?id=455388&action=review




--- Comment #11 from Darin Adler <darin at apple.com> ---
Comment on attachment 455388
  --> https://bugs.webkit.org/attachment.cgi?id=455388
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455388&action=review

> Source/WebCore/platform/network/BlobRegistryImpl.cpp:56
> +static String blobURLWithoutFragment(const URL& url)
> +{
> +    return url.hasFragmentIdentifier() ?
url.stringWithoutFragmentIdentifier().toString() : url.string();
> +}

This should probably eventually be a URL member function rather than a
blob-specific helper, even if not in this patch. Generally things that return
StringView but we want to optimize the "unchanged pre-existing String" case are
a recurring pattern. Just need the right name, I suppose. Maybe we need to
rename the existing function to viewWithoutFragmentIdentifier and this
operation can be stringWithoutFragmentIdentifier, but I hate to have this here.