[webkit-reviews] review granted: [Bug 235607] No breakpoints hit on github.com, and some are invalid : [Attachment 455396] Patch v1.4a - Fix handling multi-line comment and string error cases

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 22 11:23:53 PDT 2022


Yusuke Suzuki <ysuzuki at apple.com> has granted Patrick Angle
<pangle at apple.com>'s request for review:
Bug 235607: No breakpoints hit on github.com, and some are invalid
https://bugs.webkit.org/show_bug.cgi?id=235607

Attachment 455396: Patch v1.4a - Fix handling multi-line comment and string
error cases

https://bugs.webkit.org/attachment.cgi?id=455396&action=review




--- Comment #13 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 455396
  --> https://bugs.webkit.org/attachment.cgi?id=455396
Patch v1.4a - Fix handling multi-line comment and string error cases

View in context: https://bugs.webkit.org/attachment.cgi?id=455396&action=review

r=me

> Source/JavaScriptCore/ChangeLog:7
> +

Can you also add JSTests/stress test which caused the crash for the previous
patch? (To ensure that this new one is working).


More information about the webkit-reviews mailing list