[webkit-reviews] review granted: [Bug 238200] Move TextureMapper member variables, types and code out of GraphicsContextGLANGLE : [Attachment 455364] Patch

[bugzilla-daemon at webkit.org]

Alejandro G. Castro <alex at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 238200: Move TextureMapper member variables, types and code out of
GraphicsContextGLANGLE
https://bugs.webkit.org/show_bug.cgi?id=238200

Attachment 455364: Patch

https://bugs.webkit.org/attachment.cgi?id=455364&action=review




--- Comment #2 from Alejandro G. Castro <alex at igalia.com> ---
Comment on attachment 455364
  --> https://bugs.webkit.org/attachment.cgi?id=455364
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455364&action=review

LGTM! Great refactor, just added a small comment.

>
Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.h:8
2
> +#if USE(COORDINATED_GRAPHICS)
> +    GCGLuint m_intermediateTexture { 0 };
> +#endif
> +
> +#if USE(NICOSIA)
> +    std::unique_ptr<Nicosia::GCGLANGLELayer> m_nicosiaLayer;

Could we use remove of of the #ifs here and joing the two code sections?