[webkit-reviews] review granted: [Bug 237192] [InputElement] Add HTMLInputElement::showPicker() method : [Attachment 455360] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted zsun at igalia.com's request for review:
Bug 237192: [InputElement] Add HTMLInputElement::showPicker() method
https://bugs.webkit.org/show_bug.cgi?id=237192

Attachment 455360: Patch

https://bugs.webkit.org/attachment.cgi?id=455360&action=review




--- Comment #13 from Darin Adler <darin at apple.com> ---
Comment on attachment 455360
  --> https://bugs.webkit.org/attachment.cgi?id=455360
Patch

Looks good although it needs to be rebased. Now I am confused, though, about
how showPicker needs cross frame checks for everything except file and color,
but is only implemented for file and color. So what are the cases where
showPicker needs to forbid cross-frame access, and how are we testing those
cases? Is it about preparation for some future expansion?