[webkit-reviews] review granted: [Bug 238153] Implement CSSNumericValue.mul, div, add, sub, max, and min : [Attachment 455279] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 238153: Implement CSSNumericValue.mul, div, add, sub, max, and min
https://bugs.webkit.org/show_bug.cgi?id=238153

Attachment 455279: Patch

https://bugs.webkit.org/attachment.cgi?id=455279&action=review




--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 455279
  --> https://bugs.webkit.org/attachment.cgi?id=455279
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455279&action=review

> Source/WebCore/css/typedom/CSSNumericValue.cpp:56
> +	   return static_cast<CSSMathNegate&>(value.get()).value();

Shouldn't we be using is<> and downcast<> here and everywhere?

> Source/WebCore/css/typedom/CSSNumericValue.cpp:72
> +	   if (thisValue.unit() == "number") {

Maybe units should be AtomStrings.