[webkit-reviews] review granted: [Bug 238090] BroadcastChannel instances in distinct opaque origins can communicate : [Attachment 455265] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted  review:
Bug 238090: BroadcastChannel instances in distinct opaque origins can
communicate
https://bugs.webkit.org/show_bug.cgi?id=238090

Attachment 455265: Patch

https://bugs.webkit.org/attachment.cgi?id=455265&action=review




--- Comment #5 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 455265
  --> https://bugs.webkit.org/attachment.cgi?id=455265
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455265&action=review

> Source/WebKit/ChangeLog:14
> +	   To address the issue, I introduced a new PartitionedSecurityOrigin
type which is similar

Do you think PartitionedSecurityOrigin will eventually replace ClientOrigin, or
do we only need it in this case?

> Source/WebCore/page/PartitionedSecurityOrigin.h:74
> +    static bool equal(const WebCore::PartitionedSecurityOrigin& a, const
WebCore::PartitionedSecurityOrigin& b) { return a == b; }

This uses isSameOriginAs.  Do we want to use isSameSchemeHostPort for hash
table equivalence?

> Source/WebKit/NetworkProcess/NetworkBroadcastChannelRegistry.h:55
> +    NetworkProcess& m_networkProcess;

Can this be a Ref<NetworkProcess> instead?