[webkit-reviews] review granted: [Bug 238141] [TextureMapper] Split GraphicsContextGLTextureMapper into two classes : [Attachment 455244] Patch

[bugzilla-daemon at webkit.org]

Alejandro G. Castro <alex at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 238141: [TextureMapper] Split GraphicsContextGLTextureMapper into two
classes
https://bugs.webkit.org/show_bug.cgi?id=238141

Attachment 455244: Patch

https://bugs.webkit.org/attachment.cgi?id=455244&action=review




--- Comment #2 from Alejandro G. Castro <alex at igalia.com> ---
Comment on attachment 455244
  --> https://bugs.webkit.org/attachment.cgi?id=455244
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455244&action=review

LGTM! Check the option I pointed out to remove more code and the wincairo
failure, I think it is not related but we want to make sure we do not break it.

>
Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp
:123
> +#if USE(LIBEPOXY) && USE(OPENGL_ES) && ENABLE(WEBGL2)
> +    // Bail if GLES3 was requested but cannot be provided.
> +    if (attributes.webGLVersion == GraphicsContextGLWebGLVersion::WebGL2 &&
!epoxy_is_desktop_gl() && epoxy_gl_version() < 30)
> +	   return nullptr;
> +#endif

I think we can remove this in the ANGLE case.