[webkit-reviews] review granted: [Bug 237951] [selection] Change form's selection attribute to unsigned long : [Attachment 454968] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted zsun at igalia.com's request for
review:
Bug 237951: [selection] Change form's selection attribute to unsigned long
https://bugs.webkit.org/show_bug.cgi?id=237951

Attachment 454968: Patch

https://bugs.webkit.org/attachment.cgi?id=454968&action=review




--- Comment #10 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 454968
  --> https://bugs.webkit.org/attachment.cgi?id=454968
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454968&action=review

r=me

> Source/WebCore/html/HTMLTextFormControlElement.h:183
> +    bool m_hasCachedSelection { false };

I think personally I would have gone with a `std::optional<std::pair<unsigned,
unsigned>>` but this is fine too.