[webkit-reviews] review denied: [Bug 238130] [WebGPU] Set the WebGPU WKPreference to true in layout tests : [Attachment 455215] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 238130: [WebGPU] Set the WebGPU WKPreference to true in layout tests
https://bugs.webkit.org/show_bug.cgi?id=238130

Attachment 455215: Patch

https://bugs.webkit.org/attachment.cgi?id=455215&action=review




--- Comment #4 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 455215
  --> https://bugs.webkit.org/attachment.cgi?id=455215
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455215&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm:1593
> +- (void)_setWebGPUEnabled:(BOOL)enabled

This should not be necessary if the only place that wants to enable this is
tests.

> Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h:183
> + at property (nonatomic, setter=_setWebGPUEnabled:) BOOL _webgpuEnabled
WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));

This should not be necessary if the only place that wants to enable this is
tests.

> Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h:69
> +#define WebKitWebGPUEnabledPreferenceKey  @"WebKitWebGPU"

This should not be necessary if the only place that wants to enable this is
tests.

> Source/WebKitLegacy/mac/WebView/WebPreferences.mm:942
> +- (void)setWebgpuEnabled:(BOOL)webgpuEnabled

This should not be necessary if the only place that wants to enable this is
tests.

> Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h:259
> + at property (nonatomic) BOOL webgpuEnabled;

This should not be necessary if the only place that wants to enable this is
tests.

> Tools/DumpRenderTree/mac/DumpRenderTree.mm:882
> +	   preferences.webgpuEnabled = YES;

Instead of using new SPI, you can just add the key to
DumpRenderTree/TestOptions.cpp

> Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm:70
> +    [copiedConfiguration preferences]._webgpuEnabled = YES;

Instead of using new SPI, you can just add the key to
WebKitTestRunner/TestOptions.cpp