[webkit-reviews] review granted: [Bug 238107] [IFC][Integration] Remove redundant InlineIterator::Line::contentLogicalTopAdjustedForHitTesting : [Attachment 455164] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 238107: [IFC][Integration] Remove redundant
InlineIterator::Line::contentLogicalTopAdjustedForHitTesting
https://bugs.webkit.org/show_bug.cgi?id=238107

Attachment 455164: Patch

https://bugs.webkit.org/attachment.cgi?id=455164&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 455164
  --> https://bugs.webkit.org/attachment.cgi?id=455164
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455164&action=review

> Source/WebCore/ChangeLog:9
> +	   - containingBlock's borer and padding before

border

> Source/WebCore/layout/integration/InlineIteratorLineModernPath.h:-61
> -    float contentLogicalTopAdjustedForHitTesting() const { return
!m_lineIndex ? containingBlock().borderAndPaddingBefore().toFloat() :
contentLogicalTopAdjustedForPrecedingLine(); };

Did you forget to remove the LineLegacyPath version?