[webkit-reviews] review granted: [Bug 237982] Calc() cleanup : [Attachment 455053] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Nikos Mouchtaris
<nmouchtaris at apple.com>'s request for review:
Bug 237982: Calc() cleanup
https://bugs.webkit.org/show_bug.cgi?id=237982

Attachment 455053: Patch

https://bugs.webkit.org/attachment.cgi?id=455053&action=review




--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 455053
  --> https://bugs.webkit.org/attachment.cgi?id=455053
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455053&action=review

> Source/WebCore/css/calc/CSSCalcOperationNode.cpp:76
> +    default:

The reason to not use `default` is that the compiler will warn you if you add a
new enum value, but forget to add it to all the switch statements.

> Source/WebCore/css/calc/CSSCalcOperationNode.cpp:146
> +	   default:

Ditto.