[webkit-reviews] review granted: [Bug 237399] [WebAuthn] Give Storage Access API whenever user accepts cross-origin Webauthn prompt : [Attachment 455067] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted j_pascoe at apple.com
<j_pascoe at apple.com>'s request for review:
Bug 237399: [WebAuthn] Give Storage Access API whenever user accepts
cross-origin Webauthn prompt
https://bugs.webkit.org/show_bug.cgi?id=237399

Attachment 455067: Patch

https://bugs.webkit.org/attachment.cgi?id=455067&action=review




--- Comment #4 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 455067
  --> https://bugs.webkit.org/attachment.cgi?id=455067
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455067&action=review

r=me

> Source/WebKit/ChangeLog:10
> +	   assertion. On the apple port, the prompt required for cross-origin
assertions includes

Nit: 'Apple' port

> Source/WebCore/Modules/credentialmanagement/CredentialsContainer.cpp:62
> +	       crossOriginParent = document->securityOrigin().data();

Are these ever different when the 'isSameOriginAs' test passes? I wonder if
this part of the change is needed.