[webkit-reviews] review canceled: [Bug 237245] Trigger PDF download in captive portal mode instead of using PDF viewer : [Attachment 455095] Patch

[bugzilla-daemon at webkit.org]

Tim Nguyen (:ntim) <ntim at apple.com> has canceled j_pascoe at apple.com
<j_pascoe at apple.com>'s request for review:
Bug 237245: Trigger PDF download in captive portal mode instead of using PDF
viewer
https://bugs.webkit.org/show_bug.cgi?id=237245

Attachment 455095: Patch

https://bugs.webkit.org/attachment.cgi?id=455095&action=review




--- Comment #12 from Tim Nguyen (:ntim) <ntim at apple.com> ---
Comment on attachment 455095
  --> https://bugs.webkit.org/attachment.cgi?id=455095
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455095&action=review

> Source/WebKit/UIProcess/WebPageProxy.cpp:5726
> +	   process, navigationResponse] (PolicyAction policyAction,
API::WebsitePolicies* policies, ProcessSwapRequestedByClient
processSwapRequestedByClient, RefPtr<SafeBrowsingWarning>&&
safeBrowsingWarning, std::optional<NavigatingToAppBoundDomain>
isNavigatingToAppBoundDomain) mutable {

nit: please undo this change, which should no longer be necessary