[webkit-reviews] review granted: [Bug 236540] [GStreamer] Initial import of the GstWebRTC backend : [Attachment 455087] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 236540: [GStreamer] Initial import of the GstWebRTC backend
https://bugs.webkit.org/show_bug.cgi?id=236540

Attachment 455087: Patch

https://bugs.webkit.org/attachment.cgi?id=455087&action=review




--- Comment #55 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 455087
  --> https://bugs.webkit.org/attachment.cgi?id=455087
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455087&action=review

>
Source/WebCore/Modules/mediastream/gstreamer/GStreamerIceTransportBackend.cpp:5
4
> +    m_iceTransport.clear();

We don't need this if we land bug #238070 first.

> Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp:372
> +WEBKIT_DEFINE_ASYNC_DATA_STRUCT(SetDescriptionCallData);

; is not needed here.

> Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp:643
> +WEBKIT_DEFINE_ASYNC_DATA_STRUCT(GStreamerMediaEndpointHolder);

Ditto.

> Source/WebCore/Modules/mediastream/gstreamer/GStreamerStatsCollector.cpp:241
> +WEBKIT_DEFINE_ASYNC_DATA_STRUCT(CallbackHolder);

Ditto.

>
Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingMediaSourceGStrea
mer.cpp:148
> +    m_sender.clear();

Ditto.