[webkit-reviews] review granted: [Bug 237827] Keep service workers alive when they are inspected even though they should be terminated : [Attachment 454843] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 237827: Keep service workers alive when they are inspected even though they
should be terminated
https://bugs.webkit.org/show_bug.cgi?id=237827

Attachment 454843: Patch

https://bugs.webkit.org/attachment.cgi?id=454843&action=review




--- Comment #7 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 454843
  --> https://bugs.webkit.org/attachment.cgi?id=454843
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454843&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/PushAPI.mm:548
> +    // We delay so that the push message will happen before the
unregistration of the service worker client.
> +    sleep(0.5);

Wouldn't this be better to wait until pushMessageProcessed is true?