[webkit-reviews] review granted: [Bug 237317] PerformanceNavigationTiming Response Start unavailable when using Service Worker Cache : [Attachment 454994] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 17 11:15:54 PDT 2022


youenn fablet <youennf at gmail.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 237317: PerformanceNavigationTiming Response Start unavailable when using
Service Worker Cache
https://bugs.webkit.org/show_bug.cgi?id=237317

Attachment 454994: Patch

https://bugs.webkit.org/attachment.cgi?id=454994&action=review




--- Comment #15 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 454994
  --> https://bugs.webkit.org/attachment.cgi?id=454994
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454994&action=review

>
LayoutTests/http/wpt/service-workers/resources/navigation-timing-part-2.html:9
> +    let navTiming = performance.getEntries()[0];

Maybe add a test to check that navigator.serviceWorker.controller is not null.

>
LayoutTests/http/wpt/service-workers/resources/navigation-timing-part-2.html:10
> +    let navTimingResult = (navTiming.requestStart > 0

Could be const.


More information about the webkit-reviews mailing list