[webkit-reviews] review canceled: [Bug 237991] Fix the build with the Monterey 12.3 SDK : [Attachment 454989] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has canceled Ryan Haddad
<ryanhaddad at apple.com>'s request for review:
Bug 237991: Fix the build with the Monterey 12.3 SDK
https://bugs.webkit.org/show_bug.cgi?id=237991

Attachment 454989: Patch

https://bugs.webkit.org/attachment.cgi?id=454989&action=review




--- Comment #9 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 454989
  --> https://bugs.webkit.org/attachment.cgi?id=454989
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454989&action=review

>
Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm:51
> +    ASSERT_UNUSED(presentationModeChanged, presentationModeChanged);

This should be UNUSED_VARIABLE. ASSERT_UNUSED would fail anyway, as we just set
it to false above.

But looking further into the code, the real fix is to change an ASSERT below to
ASSERT_UNUSED. And in fact, this was also done in r291403!