[webkit-reviews] review granted: [Bug 237217] Fix test failures when enabling content filtering in the Network process : [Attachment 454972] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 237217: Fix test failures when enabling content filtering in the Network
process
https://bugs.webkit.org/show_bug.cgi?id=237217

Attachment 454972: Patch

https://bugs.webkit.org/attachment.cgi?id=454972&action=review




--- Comment #33 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 454972
  --> https://bugs.webkit.org/attachment.cgi?id=454972
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454972&action=review

r=me

> Source/WebCore/loader/DocumentLoader.cpp:144
> +    static bool filter;

Does this need a default initializer?

> Source/WebKit/WebProcess/Network/WebResourceLoader.h:105
> +    void contentFilterDidBlockLoad(const
WebCore::ContentFilterUnblockHandler&, String&& unblockRequestDeniedScript,
const WebCore::ResourceError&, const URL& blockedPageURL, 
WebCore::SubstituteData&&);

Nit: two spaces between comma and 'WebCore::SubstituteData&&'