[webkit-reviews] review granted: [Bug 238003] Allow push preference to be set programatically : [Attachment 454935] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Ben Nham <nham at apple.com>'s
request for review:
Bug 238003: Allow push preference to be set programatically
https://bugs.webkit.org/show_bug.cgi?id=238003

Attachment 454935: Patch

https://bugs.webkit.org/attachment.cgi?id=454935&action=review




--- Comment #2 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 454935
  --> https://bugs.webkit.org/attachment.cgi?id=454935
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454935&action=review

r=me

> Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h:182
>  @property (nonatomic, setter=_setStorageAPIEnabled:) BOOL _storageAPIEnabled
WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
>  @property (nonatomic, setter=_setAccessHandleEnabled:) BOOL
_accessHandleEnabled WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
>  @property (nonatomic, setter=_setNotificationsEnabled:) BOOL
_notificationsEnabled WK_API_AVAILABLE(macos(10.13.4), ios(WK_IOS_TBA));
> + at property (nonatomic, setter=_setPushAPIEnabled:) BOOL _pushAPIEnabled
WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
>  @property (nonatomic, setter=_setModelDocumentEnabled:) BOOL
_modelDocumentEnabled WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));

Kind of surprising to me that we have these toggles on WKPreferences, even
though they're things that can't change after a webpage has loaded -- but I
guess yours is not the first.

Do we not have a generic API for turning on an experimental feature? I believe
we do, and it is used in the Develop->Experimental Features menu. What happens
if the Experimental Feature is set to No and _setPushAPIEnabled: is set to YES?

I'll say r+ for now because this is fine; but please follow up on whether we
can use the experimental features API instead.