[webkit-reviews] review granted: [Bug 238023] [GTK][WPE] Add a public build option for PDF.js : [Attachment 454971] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at gnome.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 238023: [GTK][WPE] Add a public build option for PDF.js
https://bugs.webkit.org/show_bug.cgi?id=238023

Attachment 454971: Patch

https://bugs.webkit.org/attachment.cgi?id=454971&action=review




--- Comment #3 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 454971
  --> https://bugs.webkit.org/attachment.cgi?id=454971
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454971&action=review

> Source/WebCore/page/SecurityOrigin.cpp:127
>  #if PLATFORM(GTK) || PLATFORM(WPE)
>	   || url.protocolIs("resource")
> +#if ENABLE(PDFJS)
>	   || url.protocolIs("webkit-pdfjs-viewer")
> +#endif
>  #endif

I know we discussed this in bug #237513, but thinking about it more,
webkit-pdfjs-viewer should never be treated as a unique origin on any port.
Just move it outside the #if PLATFORM(GTK) || PLATFORM(WPE).