[webkit-reviews] review granted: [Bug 237963] Pass style builder context to CSSToLengthConversionData : [Attachment 454886] Patch

[bugzilla-daemon at webkit.org]

Antoine Quint <graouts at webkit.org> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 237963: Pass style builder context to CSSToLengthConversionData
https://bugs.webkit.org/show_bug.cgi?id=237963

Attachment 454886: Patch

https://bugs.webkit.org/attachment.cgi?id=454886&action=review




--- Comment #7 from Antoine Quint <graouts at webkit.org> ---
Comment on attachment 454886
  --> https://bugs.webkit.org/attachment.cgi?id=454886
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454886&action=review

> Source/WebCore/css/CSSToLengthConversionData.h:52
> +    CSSToLengthConversionData(const RenderStyle&, const RenderStyle*
rootStyle, const RenderStyle* parentStyle, const RenderView*);

'zoom' v. `zoom`, who should win?

> Source/WebCore/css/MediaQueryEvaluator.cpp:949
> +    return function(expression.value(), { *m_style, &defaultStyle, nullptr,
document.renderView() }, *frame, NoPrefix);

Should we ASSERT(m_style) here?