[webkit-reviews] review granted: [Bug 237993] compare-results should break down sync vs async time in Speedometer2 : [Attachment 454920] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 16 18:29:29 PDT 2022
Alexey Shvayka <ashvayka at apple.com> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 237993: compare-results should break down sync vs async time in
Speedometer2
https://bugs.webkit.org/show_bug.cgi?id=237993
Attachment 454920: patch
https://bugs.webkit.org/attachment.cgi?id=454920&action=review
--- Comment #2 from Alexey Shvayka <ashvayka at apple.com> ---
Comment on attachment 454920
--> https://bugs.webkit.org/attachment.cgi?id=454920
patch
View in context: https://bugs.webkit.org/attachment.cgi?id=454920&action=review
> Tools/Scripts/compare-results:77
> + #print(json.dumps(breakdown._results, indent=4, sort_keys=True))
nit: remove debug comment?
> Tools/Scripts/compare-results:86
> + if not syncTime:
nit: flip condition?
More information about the webkit-reviews
mailing list