[webkit-reviews] review canceled: [Bug 237988] Stop returning NodeVector from functions : [Attachment 454908] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has canceled Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 237988: Stop returning NodeVector from functions
https://bugs.webkit.org/show_bug.cgi?id=237988

Attachment 454908: Patch

https://bugs.webkit.org/attachment.cgi?id=454908&action=review




--- Comment #9 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 454908
  --> https://bugs.webkit.org/attachment.cgi?id=454908
Patch

Hmm, in some cases at least, it seems we call swap() explicitly:
e.g. `nodesForInsertion.swap(removedChildNodes);` in
`ContainerNode::removeSelfOrChildNodesForInsertion()`.

Maybe I am wrong about the cause for the swap(), I'll double check the other
instances.