[webkit-reviews] review granted: [Bug 237974] [GTK][WPE] Guard libgbm and libdrm code, make them conditional dependencies for GTK : [Attachment 454878] Patch

[bugzilla-daemon at webkit.org]

Alejandro G. Castro <alex at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 237974: [GTK][WPE] Guard libgbm and libdrm code, make them conditional
dependencies for GTK
https://bugs.webkit.org/show_bug.cgi?id=237974

Attachment 454878: Patch

https://bugs.webkit.org/attachment.cgi?id=454878&action=review




--- Comment #2 from Alejandro G. Castro <alex at igalia.com> ---
Comment on attachment 454878
  --> https://bugs.webkit.org/attachment.cgi?id=454878
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454878&action=review

Great! LGTM!

> Source/cmake/OptionsGTK.cmake:389
> +
> +    if (USE_ANGLE_WEBGL)
> +	   find_package(GBM REQUIRED)
> +	   find_package(LibDRM REQUIRED)
> +	   SET_AND_EXPOSE_TO_BUILD(USE_LIBGBM TRUE)
> +    endif ()

I would add in the file a dependency, in case someone tries to force one and
not the other, we are not planning to implement other option for ANGLE:

WEBKIT_OPTION_DEPEND(USE_ANGLE_WEBGL USE_LIBGBM)

> Source/cmake/OptionsWPE.cmake:285
> +SET_AND_EXPOSE_TO_BUILD(USE_LIBGBM TRUE)

Ditto.