[webkit-reviews] review granted: [Bug 235256] When a “autofilled and obscured” field becomes empty, turn “autofilled and obscured” off : [Attachment 454872] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Ellie Epskamp-Hunt
<eepskamphunt at apple.com>'s request for review:
Bug 235256: When a “autofilled and obscured” field becomes empty, turn
“autofilled and obscured” off
https://bugs.webkit.org/show_bug.cgi?id=235256

Attachment 454872: Patch

https://bugs.webkit.org/attachment.cgi?id=454872&action=review




--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 454872
  --> https://bugs.webkit.org/attachment.cgi?id=454872
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454872&action=review

r=me

> Source/WebCore/html/HTMLInputElement.cpp:1148
>      if (m_isAutoFilledAndViewable && value.isEmpty())
>	   setAutoFilledAndViewable(false);

Did you mean to delete this now that it's also done below?

> LayoutTests/fast/forms/input-autofilled-and-obscured.html:34
> +	   document.execCommand("Delete");

Could/Should we also tests things like `tf.value = ""` or `tf.form.reset()`?