[webkit-reviews] review granted: [Bug 237882] [WebGPU] Implement sampler creation according to the spec : [Attachment 454680] Patch

[bugzilla-daemon at webkit.org]

Kimmo Kinnunen <kkinnunen at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 237882: [WebGPU] Implement sampler creation according to the spec
https://bugs.webkit.org/show_bug.cgi?id=237882

Attachment 454680: Patch

https://bugs.webkit.org/attachment.cgi?id=454680&action=review




--- Comment #2 from Kimmo Kinnunen <kkinnunen at apple.com> ---
Comment on attachment 454680
  --> https://bugs.webkit.org/attachment.cgi?id=454680
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454680&action=review

> Source/WebGPU/WebGPU/Sampler.mm:40
> +    if (descriptor.lodMinClamp < 0)

an edge case of edge cases:
Do we have a mechanism to prevent NaNs in the floats or do we need to validate
those?
(those cause tricky failures to debug even if it's a content issue, so if
validation rejects those, maybe it'd be good use of time?)