[webkit-reviews] review granted: [Bug 237879] [WebGPU] Implement first draft of debug commands according to the spec : [Attachment 454675] Patch

[bugzilla-daemon at webkit.org]

Kimmo Kinnunen <kkinnunen at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 237879: [WebGPU] Implement first draft of debug commands according to the
spec
https://bugs.webkit.org/show_bug.cgi?id=237879

Attachment 454675: Patch

https://bugs.webkit.org/attachment.cgi?id=454675&action=review




--- Comment #3 from Kimmo Kinnunen <kkinnunen at apple.com> ---
Comment on attachment 454675
  --> https://bugs.webkit.org/attachment.cgi?id=454675
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454675&action=review

> Source/WebGPU/WebGPU/RenderPassEncoder.mm:112
> +    // There's no direct way of doing this, so we just push/pop an empty
debug group.

is this comment still valid? below we seem to insert a signpost instead of an
empty debug group