[webkit-reviews] review granted: [Bug 237871] [WebGPU] Implement first draft of buffer copying according to the spec : [Attachment 454664] Patch

[bugzilla-daemon at webkit.org]

Kimmo Kinnunen <kkinnunen at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 237871: [WebGPU] Implement first draft of buffer copying according to the
spec
https://bugs.webkit.org/show_bug.cgi?id=237871

Attachment 454664: Patch

https://bugs.webkit.org/attachment.cgi?id=454664&action=review




--- Comment #4 from Kimmo Kinnunen <kkinnunen at apple.com> ---
Comment on attachment 454664
  --> https://bugs.webkit.org/attachment.cgi?id=454664
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454664&action=review

> Source/WebGPU/WebGPU/CommandEncoder.mm:52
> +    commandBuffer.label = [NSString stringWithCString:descriptor.label
encoding:NSUTF8StringEncoding];

nullptr label remark (in case it's not handled in the fromAPI patch)

> Source/WebGPU/WebGPU/CommandsMixin.h:32
> +class CommandsMixin : public RefCounted<CommandsMixin> {

Based on this commit alone, it's not clear why would the refcounted be in the
mixin. it would indicate objects hold references to the mixin, which is counter
(my) expectation of mixins being just "way to import a bag of common
functionality"

Also having the WTF_MAKE_FAST_ALLOCATED here would imply you allocate the
mixins