[webkit-reviews] review granted: [Bug 237864] [WebGPU] Create a path of Ref<>s between Instance and Queue : [Attachment 454758] Patch

[bugzilla-daemon at webkit.org]

Kimmo Kinnunen <kkinnunen at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 237864: [WebGPU] Create a path of Ref<>s between Instance and Queue
https://bugs.webkit.org/show_bug.cgi?id=237864

Attachment 454758: Patch

https://bugs.webkit.org/attachment.cgi?id=454758&action=review




--- Comment #6 from Kimmo Kinnunen <kkinnunen at apple.com> ---
Comment on attachment 454758
  --> https://bugs.webkit.org/attachment.cgi?id=454758
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454758&action=review

> Source/WebGPU/WebGPU/Queue.h:61
> +    void scheduleWork(Instance::WorkItem&&);

Still, I think it's a bit strange to have the schedulework per class.


I'd imagine it'd be:
void Queue::someFunction()
{
    instance()->scheduleWork()
}

Queue::someFunction
  Instance::scheduleWork

instead of:
Queue::someFunction
  Queue::scheduleWork
    Device::scheduleWork
       Instance::scheduleWork