[webkit-reviews] review granted: [Bug 237898] REGRESSION (r282737): `text-shadow` is clipped : [Attachment 454774] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted zalan <zalan at apple.com>'s request for
review:
Bug 237898: REGRESSION (r282737): `text-shadow` is clipped
https://bugs.webkit.org/show_bug.cgi?id=237898

Attachment 454774: Patch

https://bugs.webkit.org/attachment.cgi?id=454774&action=review




--- Comment #7 from Darin Adler <darin at apple.com> ---
Comment on attachment 454774
  --> https://bugs.webkit.org/attachment.cgi?id=454774
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454774&action=review

> Source/WebCore/ChangeLog:9
> +	   Inflate the ink overflow rect with the text shadow values (note that
here, in the display builder we works with physical coordinates).

works -> work

>
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBui
lder.cpp:146
> +	   auto addTextShadowInkOverflow = [&] {

Not sure we need to name this lambda. Could just make it and call it.

> Source/WebCore/rendering/style/RenderStyle.h:508
> +    void getTextShadowHorizontalExtent(LayoutUnit& left, LayoutUnit& right)
const { getShadowHorizontalExtent(textShadow(), left, right); }

Should return a struct rather than using “get” style

> Source/WebCore/rendering/style/RenderStyle.h:509
> +    void getTextShadowVerticalExtent(LayoutUnit& top, LayoutUnit& bottom)
const { getShadowVerticalExtent(textShadow(), top, bottom); }

Ditto.