[webkit-reviews] review granted: [Bug 237856] [WebAuthn] Mock UI interactions whenever virtual authenticators are in use. : [Attachment 454652] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted j_pascoe at apple.com
<j_pascoe at apple.com>'s request for review:
Bug 237856: [WebAuthn] Mock UI interactions whenever virtual authenticators are
in use.
https://bugs.webkit.org/show_bug.cgi?id=237856

Attachment 454652: Patch

https://bugs.webkit.org/attachment.cgi?id=454652&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 454652
  --> https://bugs.webkit.org/attachment.cgi?id=454652
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454652&action=review

r=me

> Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.h:-100
> -    void
decidePolicyForLocalAuthenticator(CompletionHandler<void(LocalAuthenticatorPoli
cy)>&&) final;

It might be enough to just remove 'final' on these two methods, and not make
them public.

>
Source/WebKit/UIProcess/WebAuthentication/Virtual/VirtualAuthenticatorManager.h
:43
> +    void runPanel();

void runPanel() override;

This can also be 'private', since it is an override of the parent class method.