[webkit-reviews] review granted: [Bug 237915] Suspend newly created NetworkStorageManager if network process is or will be suspended : [Attachment 454748] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 237915: Suspend newly created NetworkStorageManager if network process is
or will be suspended
https://bugs.webkit.org/show_bug.cgi?id=237915

Attachment 454748: Patch

https://bugs.webkit.org/attachment.cgi?id=454748&action=review




--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 454748
  --> https://bugs.webkit.org/attachment.cgi?id=454748
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454748&action=review

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:2159
> +    m_isSuspended = false;

Please move this inside NetworkProcess::resume().

Alternatively, we could move the logic from resume() to here as I don't think
it is needed anymore. I think we use to have the logic in resume() so we could
call it from here and in suspension cancellation. However, I don't think
suspension cancellation is a thing anymore.