[webkit-reviews] review granted: [Bug 237913] Make it clearer in the loading logging when it is for the main frame or not : [Attachment 454740] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 15 13:49:46 PDT 2022


Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 237913: Make it clearer in the loading logging when it is for the main
frame or not
https://bugs.webkit.org/show_bug.cgi?id=237913

Attachment 454740: Patch

https://bugs.webkit.org/attachment.cgi?id=454740&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 454740
  --> https://bugs.webkit.org/attachment.cgi?id=454740
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454740&action=review

> Source/WebCore/page/FrameView.cpp:147
> +#define FRAMEVIEW_RELEASE_LOG(channel, fmt, ...) RELEASE_LOG(channel, "%p -
[pageID=%" PRIu64 ", frameID=%" PRIu64 ", isFrameFrame=%d] FrameView::" fmt,
this, PAGE_ID, FRAME_ID, frame().isMainFrame(), ##__VA_ARGS__)

isFrameFrame


More information about the webkit-reviews mailing list