[webkit-reviews] review canceled: [Bug 237839] CoreIPC Hardening: Add user gesture check when saving images : [Attachment 454734] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 15 11:46:06 PDT 2022


Brent Fulgham <bfulgham at webkit.org> has canceled Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 237839: CoreIPC Hardening: Add user gesture check when saving images
https://bugs.webkit.org/show_bug.cgi?id=237839

Attachment 454734: Patch

https://bugs.webkit.org/attachment.cgi?id=454734&action=review




--- Comment #9 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 454734
  --> https://bugs.webkit.org/attachment.cgi?id=454734
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454734&action=review

It looks like I need to rebase my build before I can put this patch up.

> Source/WebKit/UIProcess/WebPageProxy.h:2718
> +    StdSet<uint64_t> m_userGestureTokens;

@Chris: This duplicates work you did for the GeoLocation manager. Should we
modify GeoLocation to make use of this authentication token storage?


More information about the webkit-reviews mailing list