[webkit-reviews] review granted: [Bug 237891] RemoteGraphicsContextGLProxy omits context lost checks for back and front buffer access functions : [Attachment 454704] Patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has granted Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 237891: RemoteGraphicsContextGLProxy omits context lost checks for back and
front buffer access functions
https://bugs.webkit.org/show_bug.cgi?id=237891

Attachment 454704: Patch

https://bugs.webkit.org/attachment.cgi?id=454704&action=review




--- Comment #3 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 454704
  --> https://bugs.webkit.org/attachment.cgi?id=454704
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454704&action=review

> Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp:142
> +	   buffer.context().clearRect({ IntPoint(), buffer.backendSize() });

I’m a little confused. If the context is lost, how can you use the context to
clearRect()?