[webkit-reviews] review granted: [Bug 237828] [GStreamer] Avoid auto-selection of hole punching player : [Attachment 454589] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 15 07:31:29 PDT 2022


Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Enrique Ocaña
<eocanha at igalia.com>'s request for review:
Bug 237828: [GStreamer] Avoid auto-selection of hole punching player
https://bugs.webkit.org/show_bug.cgi?id=237828

Attachment 454589: Patch

https://bugs.webkit.org/attachment.cgi?id=454589&action=review




--- Comment #5 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 454589
  --> https://bugs.webkit.org/attachment.cgi?id=454589
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454589&action=review

>
Source/WebCore/platform/graphics/holepunch/MediaPlayerPrivateHolePunch.cpp:191
> +	   if (mimeType.isEmpty() || !(mimeTypeCache().contains(mimeType)))

!(mimeTypeCache().contains(mimeType)) -> !mimeTypeCache().contains(mimeType)


More information about the webkit-reviews mailing list