[webkit-reviews] review granted: [Bug 235710] redirectCount returns 0 when using a Service Worker : [Attachment 454599] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 235710: redirectCount returns 0 when using a Service Worker
https://bugs.webkit.org/show_bug.cgi?id=235710

Attachment 454599: Patch

https://bugs.webkit.org/attachment.cgi?id=454599&action=review




--- Comment #13 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 454599
  --> https://bugs.webkit.org/attachment.cgi?id=454599
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454599&action=review

> Source/WebKit/NetworkProcess/NetworkResourceLoader.h:247
> +    enum class IsFromServiceWorker { No, Yes };

: bool

> Source/WebKit/NetworkProcess/NetworkResourceLoader.h:249
> +    std::optional<WebCore::NetworkLoadMetrics> computeResponseMetrics(const
WebCore::ResourceResponse&);

Ideally this function would be marked as const.