[webkit-reviews] review granted: [Bug 237869] [WebGPU] Implement queue submission methods according to the spec : [Attachment 454656] Patch

[bugzilla-daemon at webkit.org]

Kimmo Kinnunen <kkinnunen at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 237869: [WebGPU] Implement queue submission methods according to the spec
https://bugs.webkit.org/show_bug.cgi?id=237869

Attachment 454656: Patch

https://bugs.webkit.org/attachment.cgi?id=454656&action=review




--- Comment #3 from Kimmo Kinnunen <kkinnunen at apple.com> ---
Comment on attachment 454656
  --> https://bugs.webkit.org/attachment.cgi?id=454656
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454656&action=review

> Source/WebGPU/WebGPU/Queue.h:73
> +    using OnSubmittedWorkDoneCallbacks =
Vector<WTF::Function<void(WGPUQueueWorkDoneStatus)>>;

completion handler aspect comes back also here.
so later on, you perhaps should switch the onsubmitted api signature to use
completion handler, as the. intention is to express "this function is valid
only for one call".