[webkit-reviews] review granted: [Bug 237861] [WebGPU] Repeated calls to wgpuDeviceGetQueue() are supposed to return the same pointer : [Attachment 454644] Patch

[bugzilla-daemon at webkit.org]

Kimmo Kinnunen <kkinnunen at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 237861: [WebGPU] Repeated calls to wgpuDeviceGetQueue() are supposed to
return the same pointer
https://bugs.webkit.org/show_bug.cgi?id=237861

Attachment 454644: Patch

https://bugs.webkit.org/attachment.cgi?id=454644&action=review




--- Comment #2 from Kimmo Kinnunen <kkinnunen at apple.com> ---
Comment on attachment 454644
  --> https://bugs.webkit.org/attachment.cgi?id=454644
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454644&action=review

> Source/WebGPU/WebGPU/Adapter.mm:123
>      // See the comment in Device::setLabel() about why we're not setting the
label here.

I think you can remove this comment.
For all intents and purposes, passing label to the device constructor counts as
initialising, e.g setting, the label for the device.

> Source/WebGPU/WebGPU/Device.mm:56
> +    if (deviceLabel && strlen(deviceLabel))

nit: we calculate the length of the label for the purpose of "isempty"