[webkit-reviews] review denied: [Bug 237192] [InputElement] Add HTMLInputElement::showPicker() method : [Attachment 454459] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied zsun at igalia.com's request for review:
Bug 237192: [InputElement] Add HTMLInputElement::showPicker() method
https://bugs.webkit.org/show_bug.cgi?id=237192

Attachment 454459: Patch

https://bugs.webkit.org/attachment.cgi?id=454459&action=review




--- Comment #8 from Darin Adler <darin at apple.com> ---
Comment on attachment 454459
  --> https://bugs.webkit.org/attachment.cgi?id=454459
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454459&action=review

review- because of the incorrect handling of null frame

> Source/WebCore/html/HTMLInputElement.cpp:1278
> +    if (!m_inputType->isFileUpload() && !m_inputType->isColorControl() &&
frame) {

Normally we would add a function to InputType for something like this named
something like allowsShowPickerAcrossFrames.

> Source/WebCore/html/HTMLInputElement.cpp:1284
> +    auto* window = frame->window();

The code above checks frame for null, but then this deferences frame without a
null check. I suggest we consider an early exit to silently and do nothing when
the frame is null. Or treat a null frame the same as a null window perhaps.