[webkit-reviews] review granted: [Bug 237810] [Mail compose] Allow copied resources with remote (HTTP/HTTPS) URLs to be pasted as attachments : [Attachment 454541] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 237810: [Mail compose] Allow copied resources with remote (HTTP/HTTPS) URLs
to be pasted as attachments
https://bugs.webkit.org/show_bug.cgi?id=237810

Attachment 454541: Patch

https://bugs.webkit.org/attachment.cgi?id=454541&action=review




--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 454541
  --> https://bugs.webkit.org/attachment.cgi?id=454541
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454541&action=review

r=me, neato :)

> Source/WebCore/editing/cocoa/WebContentReaderCocoa.mm:209
> +    return replacementType == ReplacementMethod::Attachment ||
!url.protocolIsInHTTPFamily();

NIT: I feel like this would read better as a separate if.
```
if (url.protocolIsInHTTPFamily())
    return replacementType == ReplacementMethod::Attachment;

return true;
```