[webkit-reviews] review granted: [Bug 237824] [web-animations] marker-end should support discrete animation : [Attachment 454569] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Antoine Quint
<graouts at webkit.org>'s request for review:
Bug 237824: [web-animations] marker-end should support discrete animation
https://bugs.webkit.org/show_bug.cgi?id=237824

Attachment 454569: Patch

https://bugs.webkit.org/attachment.cgi?id=454569&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 454569
  --> https://bugs.webkit.org/attachment.cgi?id=454569
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454569&action=review

> LayoutTests/imported/w3c/ChangeLog:10
> +	   Test failures are due to
SVGURIReference::fragmentIdentifierFromIRIString() rejecting the values used in
the
> +	   test which do not contain a "#". While this is not the greatest test
values for this property, this is indeed
> +	   a bug that we reject the value during parsing instead of storing it.

Might be good to fix that too (separately) even though it is not exactly what
you are focusing here on.